STM32: allow HS USB endpoints and increase USB OTG_HS endpoints number #13816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@facchinm, thank you for your changes. |
0xc0170
previously approved these changes
Oct 28, 2020
0xc0170
added
release-type: patch
|
Set as patch update (target update only) |
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Comment on lines
+347
to
+354
| #if (MBED_CONF_TARGET_USB_SPEED != USE_USB_OTG_HS) | ||
| /* 1.25 kbytes */ | ||
| MBED_ASSERT(total_bytes <= 1280); | ||
| #endif |
There was a problem hiding this comment.
I am wondering if this total_bytes calculation is really useful...
There was a problem hiding this comment.
Probably it can be avoided, there are a lot of other sanity checks in the endpoint creation phase
Comment on lines
+450
to
+456
| #if (MBED_CONF_TARGET_USB_SPEED == USE_USB_OTG_HS) | ||
| {USB_EP_ATTR_ALLOW_ALL | USB_EP_ATTR_DIR_IN_AND_OUT, 0, 0}, | ||
| #endif |
There was a problem hiding this comment.
Maybe this change can be the default configuration for all?
and then remove #if (MBED_CONF_TARGET_USB_SPEED == USE_USB_OTG_HS) ?
There was a problem hiding this comment.
Maybe, but I don't have enough hardware variety to test it 🙂
|
@facchinm Any update to answer questions from review above? |
jeromecoutant
approved these changes
Nov 6, 2020
|
@0xc0170 is any action still needed on my side since @jeromecoutant approved? |
facchinm
force-pushed
the
patch-stm32-usbhs-pull
branch
from
38e7d11 to
f1ea281
Compare
mergify
bot
dismissed
0xc0170’s stale review
Pull request has been modified.
0xc0170
approved these changes
Nov 10, 2020
|
CI restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.5.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is the first part of a PR series to support Arduino Portenta H7 .
The patchset has been split into independent PRs for an easier review.
This PR content:
This two commits can be squashed into one. The PR is independent from PORTENTA_H7 board so it can be mainlined before adding the new target
/cc @pennam @pnndra
Impact of changes
Changes are enabled if :
MBED_CONF_TARGET_USB_SPEED == USE_USB_OTG_HS
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@jeromecoutant